Skip to content

Fix pep440

Valentin Valls requested to merge valentin.valls/bliss:fix-pep440 into master

As noticed by @sfisher the package is not installable any more. Plus CI is failing (cause package are tested).

https://www.python.org/dev/peps/pep-0440

It is due to the PEP 440 which is now used by pip.

The MR fixes few issues relative to the way the version was generated in BLISS.

  • Fix subprocess arguments, cwd can't be empty
  • Convert 1.7.0-248-gc56ff6a3d into 1.7.0+248-gc56ff6a3d (to follow the PEP 440)
  • Display explicit error in case of git exception in packaging side
  • version_info was using string instead of int
  • Uses 0.0.0+master as ultimate fall back
    • For this one, i would prefer to reach a version we update manually from a config file.

BTW would't it make more meaningful to use a version like 1.8.0.dev0+248 right now?

Edited by Valentin Valls

Merge request reports