Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bliss bliss
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 543
    • Issues 543
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 143
    • Merge requests 143
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • BlissBliss
  • blissbliss
  • Merge requests
  • !3245

Redis proxy cleanup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Wout De Nolf requested to merge redis_proxy_cleanup into master Dec 07, 2020
  • Overview 0
  • Commits 4
  • Pipelines 4
  • Changes 3

Some cleanup of !3220 (merged)

  • Redis connections: the client name was set twice

  • test_redis_connections: take into account that the tango db could be accessing Redis

  • Beacon connection: calling SafeRedisProxy.close on greenlet garbage collection makes no sense (it is a reusable proxy that is greenlet-safe). Only FixedConnectionRedisDbProxy.close makes sense (not greenlet-safe).

  • Beacon connection: simplify proxy and connection pools with RedisProxyId (name, db, type). For each RedisProxyId we will have one reusable SafeRedisProxy and one Redis connection pool. We don't really need a different pool for a different name or type, but keep it for now.

Edited Dec 08, 2020 by Wout De Nolf
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: redis_proxy_cleanup