Skip to content

take 2: ctrl params for common.scans

Linus Pithan requested to merge 1367-take2-modify-ctrl_params into master

Closes #1367 (closed)

Currently we are missing a consistent and complete set of acq_params in the AcqObj (discussed with @pguillou) therefore the Validation can not applied systematically.

Even if there is a self.acq_params on the AcqObj it is not save to use it as it may not be complete e.g.

https://gitlab.esrf.fr/bliss/bliss/blob/master/bliss/scanning/acquisition/lima.py#L78

For now I don't see any other option than removing the validation from Scan.update_ctrl_params.

@meyer told me that in spec there was ascan with a limited number of parameters and _ascan with an extended set of parameters. One could also imagine to do something like that and have ctrl_params only as kwarg for the _ascan to avoid the need to update the ctrl_params after scan creation...

Merge request reports