Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bliss bliss
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 543
    • Issues 543
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 145
    • Merge requests 145
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • BlissBliss
  • blissbliss
  • Merge requests
  • !1790

Flint: Use SIGTERM to close Flint in the normal way

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Valentin Valls requested to merge valentin.valls/bliss:support-coverage-for-subprocess-flint into master Nov 29, 2019
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

The tests was using kill to close Flint, as result pytest-cov was not able to reach the information relative to the coverage.

This MR catch the interruption SIGTERM and try to close the application in the normal way. Which is also better for the default use case too.

This should improve the test coverage.

Edited Nov 29, 2019 by Valentin Valls
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: support-coverage-for-subprocess-flint