Skip to content

Alternative idea for solving bug reported by Alejandro

Matias Guijarro requested to merge alt_offset_setter into master
  • new method _set_position_and_offset to set a new position and an offset
  • removed _position() method => changed _update_settings and _do_encoder_reading accordingly
  • return dial position from "dial_position" setting, or read from hardware

AH: 2016/08/14

  • Add _read_dial_and_update, updating settings on HW position read
  • Refactor dial and position methods
  • Refactoring: use settings property instead of __settings
  • Rebase on top of issue_45 branch

The following command was used for validation tests:

for t in Encoder Group MockupController Settings Slits States TgGevent; do \
    pt="tests/motors/Test$t.py"; \
    python $pt || (echo "$t failed" && false) || break; \
done

Merge request reports