Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
bliss
bliss
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 492
    • Issues 492
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge Requests 134
    • Merge Requests 134
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Bliss
  • blissbliss
  • Issues
  • #2250

Closed
Open
Opened Nov 02, 2020 by Valentin Valls@valentin.valls
  • Report abuse
  • New issue
Report abuse New issue

Dispatch bliss.tango on the project

As i play around the project structure, i feel like few things could be improved.

Here is some proposal for the content of bliss.tango

bliss/tango/servers

I feel like it would be much easier to manage it together with the relative code involved. keithley.py together with keithley_ds.py

I did not check in detail, but most of the content could be dispatched into bliss.controllers. bliss.controllers already contains servers, so it could easily contain tango servers, especially if there is a dedicated package for the controller.

As the module names are always suffixed by _ds, i feel like it's already enough to distinguish tango device server modules from other stuffs.

Plus, probably always, this runnable modules are never imported, and only referenced by setup.py. It makes a change in the package name really easy.

bliss/tango/db_access

If we agree to create bliss.beacon, as this module is powered by beacon, i think it would be better to move it inside bliss.beacon.

bliss/tango/clients/utils.py

Sounds like a duplication with bliss.common.tango. We should merge this files together.

bliss/tango/clients/bliss.py

I am not sure what it is. Probably a remote BLISS client using Tango as RPC?

It could use something else than Tango at one point. So i feel like it is not tango related.

Could be moved as bliss/client.py.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
2
Labels
project proposal
Assign labels
  • View project labels
Reference: bliss/bliss#2250