Front end control questions
Looking into the front end code related to #1506 (closed) I got some surprises. Did things change on the machine side? The "cannot execute if device is in wrong state" for open/close is a bit surprising to me.
-
we needed a simple option to say whether beam can come into the hutch (e.g. in
FAULT
state there will be no beam, but this is notOPEN
orCLOSED
etc). Historically we just sentfeclose
and said "now it should be safe", but maybe we were wrong to do that. -
In spec I thought
feclose
had the effect of turning off automatic mode on the machine side when we are already closed due to injection, but maybe it did nothing?? The close command does not always get passed to the machine devices by bliss but it was always sent by spec. -
I don't find the (user) way to set/remove automatic mode (e.g.
fe._TangoShutter__control.automatic
?) -
if the front end is closed and you are in automatic mode, do you get
self.state
asCLOSED
orRUNNING
? Do we need to turn off automatic mode if we sendfe.close
in this case? -
fe.is_open
looks like it misses theRUNNING
state, although I can't test it now.
OPTICS [104]: prdef(fe.__class__.is_open.fget)
'is_open' is defined in:
/users/blissadm/local/bliss.git/bliss/common/shutter.py:85
@property
def is_open(self):
"""Check if the device is open"""
return self.state == BaseShutterState.OPEN
related to #2607 (closed) ?