Alias problem in REPL
@matias.guijarro Bug introduced by !1803 (merged). By fixing the issue of the axis names, we broke the counters.
Redis node full names (provided by StepScanDataWatch before patch):
axis:m1
simulation_diode_sampling_controller:diode2
simulation_diode_sampling_controller:diode6
Redis node names (provided by StepScanDataWatch after patch):
axis:robx
diode2alias
simulation_diode_sampling_controller:diode6
global_map.aliases
'm1': 'robx'
'simulation_diode_sampling_controller:diode2': 'diode2alias'
scan_info["acquisition_chain"]["master"]["display_names"]:
'axis:m1': 'robx'
'simulation_diode_sampling_controller:diode6': 'diode6'
'simulation_diode_sampling_controller:diode2': 'diode2alias'
ScanPrinter.on_scan_new (expected keys from StepScanDataWatch):
counter_shortnames (from acq. chain) = diode2alias, diode6
counter_fullnames (from acq. chain) = simulation_diode_sampling_controller:diode2, simulation_diode_sampling_controller:diode6
motor_fullnames (from setup_global) = axis:robx ("axis:" + setup_global.robx.name)
ScanPrinter.on_scan_data (<- StepScanDataWatch):
motors: they are ok
counters: they are not ok because sometimes we need to use the short name and sometimes the long name
Proposal: revert the patch back so that StepScanDataWatch produces a dict with the full Redis names like before. This fixes the introduced issue with the counters. To fix the original issue with the axis, use the full axis name in ScanPrinter.on_scan_new
so replace line
self.motor_fullnames.append("axis:" + motor.name)
with
self.motor_fullnames.append(channel_fullname)
I will submit a MR tomorrow if time permits.
Edited by Wout De Nolf