GitLab

+ test
+ comments

Matias Guijarro authored Mar 02, 2021 and Cyril Guilloud committed Mar 02, 2021

pi_e727: fix issue 2608, raw_write_read to not try to read multi line answers ; use raw_write_readlines instead

`raw_write_read` was trying to read multi line answers, and
once a timeout was received it meant 'message complete'.
However, timeout error in comm/tcp has the side effect of
closing the connection ; next command was re-opening a connection.
Sometimes, this reconnection occurs too fast and it is refused
by the controller.
In reality, it is much easier to know which commands return multi line
answers and to wait for those instead (no guessing).

Sebastien Petitdemange authored Nov 26, 2020 and Matias Guijarro committed Dec 23, 2020

axis: added extra properties to define velocity limits and apply_config + settings_to_config management

Check if an axis can move or not is now done in the controller.

The real home move direction may depend on the configured home
source -  it can be 1 or -1 (positive or negative direction),
but it can also be Lim+ or Lim- or even 0 (hardware decides).
So, it is better to not display something wrong here.

- It's never not a bad idea to use it

Preserve the same behaviour as normal settings, regarding config and events
Methods which were defined in ControllerAxisSettings but which belong more to AxisSettings class were moved

This was missing for 'limits' setter, for example ; better to have them
all, than counting on init. when accessing a property in another prop.

motor settings: use 'disable_cache' to disable settings on NoSettingsAxis, instead of ignoring settings completely

+ link settings with configuration

On restart, doesn't take the limit set but the configuration ones.