Incompatible shutter statees
Created by: rhfogh
The states for different kinds of shutters are incompatible, some use 'OPEN', some use 'opened', and the code that checks is not handling this confusion properly. How should this be fixed? Which is the standard? Who is empowered to modify all code to fit? In the interim I shallp ut in any old hack to get my tests to run
This give me the following error when trying to run in mock mode:
2019-04-24 13:22:01,148 |GUI |WARNING| Data collect is disabled 2019-04-24 13:22:01,148 |GUI |WARNING| - Safety shutter is closed (Open the safety shutter to enable collections)
Looking at the states, you have :
AbstractNSTate:@ class ShutterState(IntEnum): """ Defines the valid Shutter states """ UNKOWN = 0 CLOSED = 1 OPEN = 2 MOVING = 3 AUTOMATIC = 4 DISABLED = 5 FAULT = -1 ERROR = -2
class EMBLSafetyShutter(Device): """ EMBLSafetyShutter defines interface to DESY ics """
shutter_state_list = {
3: "unknown",
1: "closed",
0: "opened",
9: "moving",
17: "automatic",
23: "fault",
46: "disabled",
-1: "error",
}
class MDFastShutter(Device): """ MD Fast shutter """ shutterState = {3: "unknown", 1: "closed", 0: "opened", 46: "disabled"}